v3.1: deprecate the --cuda cli argument (backport of #9055) (#9066)

* deprecate the --cuda cli argument (#9055)

deprecate the CUDA cli argument

(cherry picked from commit 7aabaec63290d694d8ac90d2e1431af5dcd39ef0)

* fix order of args

---------

Co-authored-by: Alex Pyattaev <alex.pyattaev@anza.xyz>

validator/src/cli.rs

@@ -179,6 +179,14 @@ fn deprecated_arguments() -> Vec<DeprecatedArg> {
             ),
             usage_warning: "The accounts hash cache is obsolete",
     );
+    add_arg!(
+        // deprecated in v3.1.1
+        Arg::with_name("cuda")
+            .long("cuda")
+            .takes_value(false)
+            .help("Use CUDA"),
+        usage_warning: "CUDA support will be dropped"
+    );
     add_arg!(Arg::with_name("disable_accounts_disk_index")
         // (actually) deprecated in v3.1.0
         .long("disable-accounts-disk-index")

validator/src/commands/run/args.rs

@@ -615,12 +615,6 @@ pub fn add_args<'a>(app: App<'a, 'a>, default_args: &'a DefaultArgs) -> App<'a,
             .takes_value(false)
             .help("Skip ledger verification at validator bootup."),
     )
-    .arg(
-        Arg::with_name("cuda")
-            .long("cuda")
-            .takes_value(false)
-            .help("Use CUDA"),
-    )
     .arg(
         clap::Arg::with_name("require_tower")
             .long("require-tower")