GovernorPreventLateQuorum.test.js 7.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172
  1. const { BN, expectEvent, expectRevert } = require('@openzeppelin/test-helpers');
  2. const { expect } = require('chai');
  3. const Enums = require('../../helpers/enums');
  4. const { GovernorHelper } = require('../../helpers/governance');
  5. const Token = artifacts.require('$ERC20VotesComp');
  6. const Governor = artifacts.require('$GovernorPreventLateQuorumMock');
  7. const CallReceiver = artifacts.require('CallReceiverMock');
  8. contract('GovernorPreventLateQuorum', function (accounts) {
  9. const [owner, proposer, voter1, voter2, voter3, voter4] = accounts;
  10. const name = 'OZ-Governor';
  11. // const version = '1';
  12. const tokenName = 'MockToken';
  13. const tokenSymbol = 'MTKN';
  14. const tokenSupply = web3.utils.toWei('100');
  15. const votingDelay = new BN(4);
  16. const votingPeriod = new BN(16);
  17. const lateQuorumVoteExtension = new BN(8);
  18. const quorum = web3.utils.toWei('1');
  19. const value = web3.utils.toWei('1');
  20. beforeEach(async function () {
  21. this.owner = owner;
  22. this.token = await Token.new(tokenName, tokenSymbol, tokenName);
  23. this.mock = await Governor.new(
  24. name,
  25. votingDelay,
  26. votingPeriod,
  27. 0,
  28. this.token.address,
  29. lateQuorumVoteExtension,
  30. quorum,
  31. );
  32. this.receiver = await CallReceiver.new();
  33. this.helper = new GovernorHelper(this.mock);
  34. await web3.eth.sendTransaction({ from: owner, to: this.mock.address, value });
  35. await this.token.$_mint(owner, tokenSupply);
  36. await this.helper.delegate({ token: this.token, to: voter1, value: web3.utils.toWei('10') }, { from: owner });
  37. await this.helper.delegate({ token: this.token, to: voter2, value: web3.utils.toWei('7') }, { from: owner });
  38. await this.helper.delegate({ token: this.token, to: voter3, value: web3.utils.toWei('5') }, { from: owner });
  39. await this.helper.delegate({ token: this.token, to: voter4, value: web3.utils.toWei('2') }, { from: owner });
  40. // default proposal
  41. this.proposal = this.helper.setProposal(
  42. [
  43. {
  44. target: this.receiver.address,
  45. value,
  46. data: this.receiver.contract.methods.mockFunction().encodeABI(),
  47. },
  48. ],
  49. '<proposal description>',
  50. );
  51. });
  52. it('deployment check', async function () {
  53. expect(await this.mock.name()).to.be.equal(name);
  54. expect(await this.mock.token()).to.be.equal(this.token.address);
  55. expect(await this.mock.votingDelay()).to.be.bignumber.equal(votingDelay);
  56. expect(await this.mock.votingPeriod()).to.be.bignumber.equal(votingPeriod);
  57. expect(await this.mock.quorum(0)).to.be.bignumber.equal(quorum);
  58. expect(await this.mock.lateQuorumVoteExtension()).to.be.bignumber.equal(lateQuorumVoteExtension);
  59. });
  60. it('nominal workflow unaffected', async function () {
  61. const txPropose = await this.helper.propose({ from: proposer });
  62. await this.helper.waitForSnapshot();
  63. await this.helper.vote({ support: Enums.VoteType.For }, { from: voter1 });
  64. await this.helper.vote({ support: Enums.VoteType.For }, { from: voter2 });
  65. await this.helper.vote({ support: Enums.VoteType.Against }, { from: voter3 });
  66. await this.helper.vote({ support: Enums.VoteType.Abstain }, { from: voter4 });
  67. await this.helper.waitForDeadline();
  68. await this.helper.execute();
  69. expect(await this.mock.hasVoted(this.proposal.id, owner)).to.be.equal(false);
  70. expect(await this.mock.hasVoted(this.proposal.id, voter1)).to.be.equal(true);
  71. expect(await this.mock.hasVoted(this.proposal.id, voter2)).to.be.equal(true);
  72. expect(await this.mock.hasVoted(this.proposal.id, voter3)).to.be.equal(true);
  73. expect(await this.mock.hasVoted(this.proposal.id, voter4)).to.be.equal(true);
  74. await this.mock.proposalVotes(this.proposal.id).then(results => {
  75. expect(results.forVotes).to.be.bignumber.equal(web3.utils.toWei('17'));
  76. expect(results.againstVotes).to.be.bignumber.equal(web3.utils.toWei('5'));
  77. expect(results.abstainVotes).to.be.bignumber.equal(web3.utils.toWei('2'));
  78. });
  79. const startBlock = new BN(txPropose.receipt.blockNumber).add(votingDelay);
  80. const endBlock = new BN(txPropose.receipt.blockNumber).add(votingDelay).add(votingPeriod);
  81. expect(await this.mock.proposalSnapshot(this.proposal.id)).to.be.bignumber.equal(startBlock);
  82. expect(await this.mock.proposalDeadline(this.proposal.id)).to.be.bignumber.equal(endBlock);
  83. expectEvent(txPropose, 'ProposalCreated', {
  84. proposalId: this.proposal.id,
  85. proposer,
  86. targets: this.proposal.targets,
  87. // values: this.proposal.values.map(value => new BN(value)),
  88. signatures: this.proposal.signatures,
  89. calldatas: this.proposal.data,
  90. startBlock,
  91. endBlock,
  92. description: this.proposal.description,
  93. });
  94. });
  95. it('Delay is extended to prevent last minute take-over', async function () {
  96. const txPropose = await this.helper.propose({ from: proposer });
  97. // compute original schedule
  98. const startBlock = new BN(txPropose.receipt.blockNumber).add(votingDelay);
  99. const endBlock = new BN(txPropose.receipt.blockNumber).add(votingDelay).add(votingPeriod);
  100. expect(await this.mock.proposalSnapshot(this.proposal.id)).to.be.bignumber.equal(startBlock);
  101. expect(await this.mock.proposalDeadline(this.proposal.id)).to.be.bignumber.equal(endBlock);
  102. // wait for the last minute to vote
  103. await this.helper.waitForDeadline(-1);
  104. const txVote = await this.helper.vote({ support: Enums.VoteType.For }, { from: voter2 });
  105. // cannot execute yet
  106. expect(await this.mock.state(this.proposal.id)).to.be.bignumber.equal(Enums.ProposalState.Active);
  107. // compute new extended schedule
  108. const extendedDeadline = new BN(txVote.receipt.blockNumber).add(lateQuorumVoteExtension);
  109. expect(await this.mock.proposalSnapshot(this.proposal.id)).to.be.bignumber.equal(startBlock);
  110. expect(await this.mock.proposalDeadline(this.proposal.id)).to.be.bignumber.equal(extendedDeadline);
  111. // still possible to vote
  112. await this.helper.vote({ support: Enums.VoteType.Against }, { from: voter1 });
  113. await this.helper.waitForDeadline();
  114. expect(await this.mock.state(this.proposal.id)).to.be.bignumber.equal(Enums.ProposalState.Active);
  115. await this.helper.waitForDeadline(+1);
  116. expect(await this.mock.state(this.proposal.id)).to.be.bignumber.equal(Enums.ProposalState.Defeated);
  117. // check extension event
  118. expectEvent(txVote, 'ProposalExtended', { proposalId: this.proposal.id, extendedDeadline });
  119. });
  120. describe('onlyGovernance updates', function () {
  121. it('setLateQuorumVoteExtension is protected', async function () {
  122. await expectRevert(this.mock.setLateQuorumVoteExtension(0), 'Governor: onlyGovernance');
  123. });
  124. it('can setLateQuorumVoteExtension through governance', async function () {
  125. this.helper.setProposal(
  126. [
  127. {
  128. target: this.mock.address,
  129. data: this.mock.contract.methods.setLateQuorumVoteExtension('0').encodeABI(),
  130. },
  131. ],
  132. '<proposal description>',
  133. );
  134. await this.helper.propose();
  135. await this.helper.waitForSnapshot();
  136. await this.helper.vote({ support: Enums.VoteType.For }, { from: voter1 });
  137. await this.helper.waitForDeadline();
  138. expectEvent(await this.helper.execute(), 'LateQuorumVoteExtensionSet', {
  139. oldVoteExtension: lateQuorumVoteExtension,
  140. newVoteExtension: '0',
  141. });
  142. expect(await this.mock.lateQuorumVoteExtension()).to.be.bignumber.equal('0');
  143. });
  144. });
  145. });