TransparentUpgradeableProxy.sol 5.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107
  1. // SPDX-License-Identifier: MIT
  2. // OpenZeppelin Contracts (last updated v4.9.0) (proxy/transparent/TransparentUpgradeableProxy.sol)
  3. pragma solidity ^0.8.20;
  4. import {ERC1967Utils} from "../ERC1967/ERC1967Utils.sol";
  5. import {ERC1967Proxy} from "../ERC1967/ERC1967Proxy.sol";
  6. import {IERC1967} from "../../interfaces/IERC1967.sol";
  7. import {ProxyAdmin} from "./ProxyAdmin.sol";
  8. /**
  9. * @dev Interface for {TransparentUpgradeableProxy}. In order to implement transparency, {TransparentUpgradeableProxy}
  10. * does not implement this interface directly, and its upgradeability mechanism is implemented by an internal dispatch
  11. * mechanism. The compiler is unaware that these functions are implemented by {TransparentUpgradeableProxy} and will not
  12. * include them in the ABI so this interface must be used to interact with it.
  13. */
  14. interface ITransparentUpgradeableProxy is IERC1967 {
  15. function upgradeToAndCall(address, bytes calldata) external payable;
  16. }
  17. /**
  18. * @dev This contract implements a proxy that is upgradeable through an associated {ProxyAdmin} instance.
  19. *
  20. * To avoid https://medium.com/nomic-labs-blog/malicious-backdoors-in-ethereum-proxies-62629adf3357[proxy selector
  21. * clashing], which can potentially be used in an attack, this contract uses the
  22. * https://blog.openzeppelin.com/the-transparent-proxy-pattern/[transparent proxy pattern]. This pattern implies two
  23. * things that go hand in hand:
  24. *
  25. * 1. If any account other than the admin calls the proxy, the call will be forwarded to the implementation, even if
  26. * that call matches the {ITransparentUpgradeableProxy-upgradeToAndCall} function exposed by the proxy itself.
  27. * 2. If the admin calls the proxy, it can call the `upgradeToAndCall` function but any other call won't be forwarded to the
  28. * implementation. If the admin tries to call a function on the implementation it will fail with an error indicating the
  29. * proxy admin cannot fallback to the target implementation.
  30. *
  31. * These properties mean that the admin account can only be used for upgrading the proxy, so it's best if it's a dedicated
  32. * account that is not used for anything else. This will avoid headaches due to sudden errors when trying to call a function
  33. * from the proxy implementation. For this reason, the proxy deploys an instance of {ProxyAdmin} and allows upgrades
  34. * only if they come through it.
  35. * You should think of the `ProxyAdmin` instance as the administrative interface of the proxy, including the ability to
  36. * change who can trigger upgrades by transferring ownership.
  37. *
  38. * NOTE: The real interface of this proxy is that defined in `ITransparentUpgradeableProxy`. This contract does not
  39. * inherit from that interface, and instead `upgradeToAndCall` is implicitly implemented using a custom dispatch mechanism
  40. * in `_fallback`. Consequently, the compiler will not produce an ABI for this contract. This is necessary to fully
  41. * implement transparency without decoding reverts caused by selector clashes between the proxy and the
  42. * implementation.
  43. *
  44. * IMPORTANT: This contract avoids unnecessary storage reads by setting the admin only during construction as an immutable variable,
  45. * preventing any changes thereafter. However, the admin slot defined in ERC-1967 can still be overwritten by the implementation
  46. * logic pointed to by this proxy. In such cases, the contract may end up in an undesirable state where the admin slot is different
  47. * from the actual admin.
  48. *
  49. * WARNING: It is not recommended to extend this contract to add additional external functions. If you do so, the compiler
  50. * will not check that there are no selector conflicts, due to the note above. A selector clash between any new function
  51. * and the functions declared in {ITransparentUpgradeableProxy} will be resolved in favor of the new one. This could
  52. * render the `upgradeToAndCall` function inaccessible, preventing upgradeability and compromising transparency.
  53. */
  54. contract TransparentUpgradeableProxy is ERC1967Proxy {
  55. // An immutable address for the admin to avoid unnecessary SLOADs before each call
  56. // at the expense of removing the ability to change the admin once it's set.
  57. // This is acceptable if the admin is always a ProxyAdmin instance or similar contract
  58. // with its own ability to transfer the permissions to another account.
  59. address private immutable _admin;
  60. /**
  61. * @dev The proxy caller is the current admin, and can't fallback to the proxy target.
  62. */
  63. error ProxyDeniedAdminAccess();
  64. /**
  65. * @dev Initializes an upgradeable proxy managed by an instance of a {ProxyAdmin} with an `initialOwner`,
  66. * backed by the implementation at `_logic`, and optionally initialized with `_data` as explained in
  67. * {ERC1967Proxy-constructor}.
  68. */
  69. constructor(address _logic, address initialOwner, bytes memory _data) payable ERC1967Proxy(_logic, _data) {
  70. _admin = address(new ProxyAdmin(initialOwner));
  71. // Set the storage value and emit an event for ERC-1967 compatibility
  72. ERC1967Utils.changeAdmin(_admin);
  73. }
  74. /**
  75. * @dev If caller is the admin process the call internally, otherwise transparently fallback to the proxy behavior.
  76. */
  77. function _fallback() internal virtual override {
  78. if (msg.sender == _admin) {
  79. if (msg.sig == ITransparentUpgradeableProxy.upgradeToAndCall.selector) {
  80. _dispatchUpgradeToAndCall();
  81. } else {
  82. revert ProxyDeniedAdminAccess();
  83. }
  84. } else {
  85. super._fallback();
  86. }
  87. }
  88. /**
  89. * @dev Upgrade the implementation of the proxy. See {ERC1967Utils-upgradeToAndCall}.
  90. *
  91. * Requirements:
  92. *
  93. * - If `data` is empty, `msg.value` must be zero.
  94. */
  95. function _dispatchUpgradeToAndCall() private {
  96. (address newImplementation, bytes memory data) = abi.decode(msg.data[4:], (address, bytes));
  97. ERC1967Utils.upgradeToAndCall(newImplementation, data);
  98. }
  99. }