TransparentUpgradeableProxy.sol 6.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116
  1. // SPDX-License-Identifier: MIT
  2. // OpenZeppelin Contracts (last updated v4.9.0) (proxy/transparent/TransparentUpgradeableProxy.sol)
  3. pragma solidity ^0.8.20;
  4. import {ERC1967Utils} from "../ERC1967/ERC1967Utils.sol";
  5. import {ERC1967Proxy} from "../ERC1967/ERC1967Proxy.sol";
  6. import {IERC1967} from "../../interfaces/IERC1967.sol";
  7. import {ProxyAdmin} from "./ProxyAdmin.sol";
  8. /**
  9. * @dev Interface for {TransparentUpgradeableProxy}. In order to implement transparency, {TransparentUpgradeableProxy}
  10. * does not implement this interface directly, and its upgradeability mechanism is implemented by an internal dispatch
  11. * mechanism. The compiler is unaware that these functions are implemented by {TransparentUpgradeableProxy} and will not
  12. * include them in the ABI so this interface must be used to interact with it.
  13. */
  14. interface ITransparentUpgradeableProxy is IERC1967 {
  15. function upgradeToAndCall(address, bytes calldata) external payable;
  16. }
  17. /**
  18. * @dev This contract implements a proxy that is upgradeable through an associated {ProxyAdmin} instance.
  19. *
  20. * To avoid https://medium.com/nomic-labs-blog/malicious-backdoors-in-ethereum-proxies-62629adf3357[proxy selector
  21. * clashing], which can potentially be used in an attack, this contract uses the
  22. * https://blog.openzeppelin.com/the-transparent-proxy-pattern/[transparent proxy pattern]. This pattern implies two
  23. * things that go hand in hand:
  24. *
  25. * 1. If any account other than the admin calls the proxy, the call will be forwarded to the implementation, even if
  26. * that call matches the {ITransparentUpgradeableProxy-upgradeToAndCall} function exposed by the proxy itself.
  27. * 2. If the admin calls the proxy, it can call the `upgradeToAndCall` function but any other call won't be forwarded to
  28. * the implementation. If the admin tries to call a function on the implementation it will fail with an error indicating
  29. * the proxy admin cannot fallback to the target implementation.
  30. *
  31. * These properties mean that the admin account can only be used for upgrading the proxy, so it's best if it's a
  32. * dedicated account that is not used for anything else. This will avoid headaches due to sudden errors when trying to
  33. * call a function from the proxy implementation. For this reason, the proxy deploys an instance of {ProxyAdmin} and
  34. * allows upgrades only if they come through it. You should think of the `ProxyAdmin` instance as the administrative
  35. * interface of the proxy, including the ability to change who can trigger upgrades by transferring ownership.
  36. *
  37. * NOTE: The real interface of this proxy is that defined in `ITransparentUpgradeableProxy`. This contract does not
  38. * inherit from that interface, and instead `upgradeToAndCall` is implicitly implemented using a custom dispatch
  39. * mechanism in `_fallback`. Consequently, the compiler will not produce an ABI for this contract. This is necessary to
  40. * fully implement transparency without decoding reverts caused by selector clashes between the proxy and the
  41. * implementation.
  42. *
  43. * NOTE: This proxy does not inherit from {Context} deliberately. The {ProxyAdmin} of this contract won't send a
  44. * meta-transaction in any way, and any other meta-transaction setup should be made in the implementation contract.
  45. *
  46. * IMPORTANT: This contract avoids unnecessary storage reads by setting the admin only during construction as an
  47. * immutable variable, preventing any changes thereafter. However, the admin slot defined in ERC-1967 can still be
  48. * overwritten by the implementation logic pointed to by this proxy. In such cases, the contract may end up in an
  49. * undesirable state where the admin slot is different from the actual admin.
  50. *
  51. * WARNING: It is not recommended to extend this contract to add additional external functions. If you do so, the
  52. * compiler will not check that there are no selector conflicts, due to the note above. A selector clash between any new
  53. * function and the functions declared in {ITransparentUpgradeableProxy} will be resolved in favor of the new one. This
  54. * could render the `upgradeToAndCall` function inaccessible, preventing upgradeability and compromising transparency.
  55. */
  56. contract TransparentUpgradeableProxy is ERC1967Proxy {
  57. // An immutable address for the admin to avoid unnecessary SLOADs before each call
  58. // at the expense of removing the ability to change the admin once it's set.
  59. // This is acceptable if the admin is always a ProxyAdmin instance or similar contract
  60. // with its own ability to transfer the permissions to another account.
  61. address private immutable _admin;
  62. /**
  63. * @dev The proxy caller is the current admin, and can't fallback to the proxy target.
  64. */
  65. error ProxyDeniedAdminAccess();
  66. /**
  67. * @dev Initializes an upgradeable proxy managed by an instance of a {ProxyAdmin} with an `initialOwner`,
  68. * backed by the implementation at `_logic`, and optionally initialized with `_data` as explained in
  69. * {ERC1967Proxy-constructor}.
  70. */
  71. constructor(address _logic, address initialOwner, bytes memory _data) payable ERC1967Proxy(_logic, _data) {
  72. _admin = address(new ProxyAdmin(initialOwner));
  73. // Set the storage value and emit an event for ERC-1967 compatibility
  74. ERC1967Utils.changeAdmin(_proxyAdmin());
  75. }
  76. /**
  77. * @dev Returns the admin of this proxy.
  78. */
  79. function _proxyAdmin() internal virtual returns (address) {
  80. return _admin;
  81. }
  82. /**
  83. * @dev If caller is the admin process the call internally, otherwise transparently fallback to the proxy behavior.
  84. */
  85. function _fallback() internal virtual override {
  86. if (msg.sender == _proxyAdmin()) {
  87. if (msg.sig != ITransparentUpgradeableProxy.upgradeToAndCall.selector) {
  88. revert ProxyDeniedAdminAccess();
  89. } else {
  90. _dispatchUpgradeToAndCall();
  91. }
  92. } else {
  93. super._fallback();
  94. }
  95. }
  96. /**
  97. * @dev Upgrade the implementation of the proxy. See {ERC1967Utils-upgradeToAndCall}.
  98. *
  99. * Requirements:
  100. *
  101. * - If `data` is empty, `msg.value` must be zero.
  102. */
  103. function _dispatchUpgradeToAndCall() private {
  104. (address newImplementation, bytes memory data) = abi.decode(msg.data[4:], (address, bytes));
  105. ERC1967Utils.upgradeToAndCall(newImplementation, data);
  106. }
  107. }