GovernorPreventLateQuorum.test.js 7.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178
  1. const { BN, expectEvent, expectRevert } = require('@openzeppelin/test-helpers');
  2. const { expect } = require('chai');
  3. const Enums = require('../../helpers/enums');
  4. const { GovernorHelper } = require('../../helpers/governance');
  5. const Token = artifacts.require('$ERC20VotesComp');
  6. const Governor = artifacts.require('$GovernorPreventLateQuorumMock');
  7. const CallReceiver = artifacts.require('CallReceiverMock');
  8. contract('GovernorPreventLateQuorum', function (accounts) {
  9. const [ owner, proposer, voter1, voter2, voter3, voter4 ] = accounts;
  10. const name = 'OZ-Governor';
  11. // const version = '1';
  12. const tokenName = 'MockToken';
  13. const tokenSymbol = 'MTKN';
  14. const tokenSupply = web3.utils.toWei('100');
  15. const votingDelay = new BN(4);
  16. const votingPeriod = new BN(16);
  17. const lateQuorumVoteExtension = new BN(8);
  18. const quorum = web3.utils.toWei('1');
  19. const value = web3.utils.toWei('1');
  20. beforeEach(async function () {
  21. this.owner = owner;
  22. this.token = await Token.new(tokenName, tokenSymbol, tokenName);
  23. this.mock = await Governor.new(
  24. name,
  25. votingDelay,
  26. votingPeriod,
  27. 0,
  28. this.token.address,
  29. lateQuorumVoteExtension,
  30. quorum,
  31. );
  32. this.receiver = await CallReceiver.new();
  33. this.helper = new GovernorHelper(this.mock);
  34. await web3.eth.sendTransaction({ from: owner, to: this.mock.address, value });
  35. await this.token.$_mint(owner, tokenSupply);
  36. await this.helper.delegate({ token: this.token, to: voter1, value: web3.utils.toWei('10') }, { from: owner });
  37. await this.helper.delegate({ token: this.token, to: voter2, value: web3.utils.toWei('7') }, { from: owner });
  38. await this.helper.delegate({ token: this.token, to: voter3, value: web3.utils.toWei('5') }, { from: owner });
  39. await this.helper.delegate({ token: this.token, to: voter4, value: web3.utils.toWei('2') }, { from: owner });
  40. // default proposal
  41. this.proposal = this.helper.setProposal([
  42. {
  43. target: this.receiver.address,
  44. value,
  45. data: this.receiver.contract.methods.mockFunction().encodeABI(),
  46. },
  47. ], '<proposal description>');
  48. });
  49. it('deployment check', async function () {
  50. expect(await this.mock.name()).to.be.equal(name);
  51. expect(await this.mock.token()).to.be.equal(this.token.address);
  52. expect(await this.mock.votingDelay()).to.be.bignumber.equal(votingDelay);
  53. expect(await this.mock.votingPeriod()).to.be.bignumber.equal(votingPeriod);
  54. expect(await this.mock.quorum(0)).to.be.bignumber.equal(quorum);
  55. expect(await this.mock.lateQuorumVoteExtension()).to.be.bignumber.equal(lateQuorumVoteExtension);
  56. });
  57. it('nominal workflow unaffected', async function () {
  58. const txPropose = await this.helper.propose({ from: proposer });
  59. await this.helper.waitForSnapshot();
  60. await this.helper.vote({ support: Enums.VoteType.For }, { from: voter1 });
  61. await this.helper.vote({ support: Enums.VoteType.For }, { from: voter2 });
  62. await this.helper.vote({ support: Enums.VoteType.Against }, { from: voter3 });
  63. await this.helper.vote({ support: Enums.VoteType.Abstain }, { from: voter4 });
  64. await this.helper.waitForDeadline();
  65. await this.helper.execute();
  66. expect(await this.mock.hasVoted(this.proposal.id, owner)).to.be.equal(false);
  67. expect(await this.mock.hasVoted(this.proposal.id, voter1)).to.be.equal(true);
  68. expect(await this.mock.hasVoted(this.proposal.id, voter2)).to.be.equal(true);
  69. expect(await this.mock.hasVoted(this.proposal.id, voter3)).to.be.equal(true);
  70. expect(await this.mock.hasVoted(this.proposal.id, voter4)).to.be.equal(true);
  71. await this.mock.proposalVotes(this.proposal.id).then(results => {
  72. expect(results.forVotes).to.be.bignumber.equal(web3.utils.toWei('17'));
  73. expect(results.againstVotes).to.be.bignumber.equal(web3.utils.toWei('5'));
  74. expect(results.abstainVotes).to.be.bignumber.equal(web3.utils.toWei('2'));
  75. });
  76. const startBlock = new BN(txPropose.receipt.blockNumber).add(votingDelay);
  77. const endBlock = new BN(txPropose.receipt.blockNumber).add(votingDelay).add(votingPeriod);
  78. expect(await this.mock.proposalSnapshot(this.proposal.id)).to.be.bignumber.equal(startBlock);
  79. expect(await this.mock.proposalDeadline(this.proposal.id)).to.be.bignumber.equal(endBlock);
  80. expectEvent(
  81. txPropose,
  82. 'ProposalCreated',
  83. {
  84. proposalId: this.proposal.id,
  85. proposer,
  86. targets: this.proposal.targets,
  87. // values: this.proposal.values.map(value => new BN(value)),
  88. signatures: this.proposal.signatures,
  89. calldatas: this.proposal.data,
  90. startBlock,
  91. endBlock,
  92. description: this.proposal.description,
  93. },
  94. );
  95. });
  96. it('Delay is extended to prevent last minute take-over', async function () {
  97. const txPropose = await this.helper.propose({ from: proposer });
  98. // compute original schedule
  99. const startBlock = new BN(txPropose.receipt.blockNumber).add(votingDelay);
  100. const endBlock = new BN(txPropose.receipt.blockNumber).add(votingDelay).add(votingPeriod);
  101. expect(await this.mock.proposalSnapshot(this.proposal.id)).to.be.bignumber.equal(startBlock);
  102. expect(await this.mock.proposalDeadline(this.proposal.id)).to.be.bignumber.equal(endBlock);
  103. // wait for the last minute to vote
  104. await this.helper.waitForDeadline(-1);
  105. const txVote = await this.helper.vote({ support: Enums.VoteType.For }, { from: voter2 });
  106. // cannot execute yet
  107. expect(await this.mock.state(this.proposal.id)).to.be.bignumber.equal(Enums.ProposalState.Active);
  108. // compute new extended schedule
  109. const extendedDeadline = new BN(txVote.receipt.blockNumber).add(lateQuorumVoteExtension);
  110. expect(await this.mock.proposalSnapshot(this.proposal.id)).to.be.bignumber.equal(startBlock);
  111. expect(await this.mock.proposalDeadline(this.proposal.id)).to.be.bignumber.equal(extendedDeadline);
  112. // still possible to vote
  113. await this.helper.vote({ support: Enums.VoteType.Against }, { from: voter1 });
  114. await this.helper.waitForDeadline();
  115. expect(await this.mock.state(this.proposal.id)).to.be.bignumber.equal(Enums.ProposalState.Active);
  116. await this.helper.waitForDeadline(+1);
  117. expect(await this.mock.state(this.proposal.id)).to.be.bignumber.equal(Enums.ProposalState.Defeated);
  118. // check extension event
  119. expectEvent(
  120. txVote,
  121. 'ProposalExtended',
  122. { proposalId: this.proposal.id, extendedDeadline },
  123. );
  124. });
  125. describe('onlyGovernance updates', function () {
  126. it('setLateQuorumVoteExtension is protected', async function () {
  127. await expectRevert(
  128. this.mock.setLateQuorumVoteExtension(0),
  129. 'Governor: onlyGovernance',
  130. );
  131. });
  132. it('can setLateQuorumVoteExtension through governance', async function () {
  133. this.helper.setProposal([
  134. {
  135. target: this.mock.address,
  136. data: this.mock.contract.methods.setLateQuorumVoteExtension('0').encodeABI(),
  137. },
  138. ], '<proposal description>');
  139. await this.helper.propose();
  140. await this.helper.waitForSnapshot();
  141. await this.helper.vote({ support: Enums.VoteType.For }, { from: voter1 });
  142. await this.helper.waitForDeadline();
  143. expectEvent(
  144. await this.helper.execute(),
  145. 'LateQuorumVoteExtensionSet',
  146. { oldVoteExtension: lateQuorumVoteExtension, newVoteExtension: '0' },
  147. );
  148. expect(await this.mock.lateQuorumVoteExtension()).to.be.bignumber.equal('0');
  149. });
  150. });
  151. });