TransparentUpgradeableProxy.sol 6.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141
  1. // SPDX-License-Identifier: MIT
  2. // OpenZeppelin Contracts (last updated v4.9.0) (proxy/transparent/TransparentUpgradeableProxy.sol)
  3. pragma solidity ^0.8.19;
  4. import "../ERC1967/ERC1967Proxy.sol";
  5. import "../../interfaces/IERC1967.sol";
  6. /**
  7. * @dev Interface for {TransparentUpgradeableProxy}. In order to implement transparency, {TransparentUpgradeableProxy}
  8. * does not implement this interface directly, and some of its functions are implemented by an internal dispatch
  9. * mechanism. The compiler is unaware that these functions are implemented by {TransparentUpgradeableProxy} and will not
  10. * include them in the ABI so this interface must be used to interact with it.
  11. */
  12. interface ITransparentUpgradeableProxy is IERC1967 {
  13. function upgradeTo(address) external;
  14. function upgradeToAndCall(address, bytes memory) external payable;
  15. }
  16. /**
  17. * @dev This contract implements a proxy that is upgradeable by an immutable admin.
  18. *
  19. * To avoid https://medium.com/nomic-labs-blog/malicious-backdoors-in-ethereum-proxies-62629adf3357[proxy selector
  20. * clashing], which can potentially be used in an attack, this contract uses the
  21. * https://blog.openzeppelin.com/the-transparent-proxy-pattern/[transparent proxy pattern]. This pattern implies two
  22. * things that go hand in hand:
  23. *
  24. * 1. If any account other than the admin calls the proxy, the call will be forwarded to the implementation, even if
  25. * that call matches one of the admin functions exposed by the proxy itself.
  26. * 2. If the admin calls the proxy, it can access the admin functions, but its calls will never be forwarded to the
  27. * implementation. If the admin tries to call a function on the implementation it will fail with an error indicating the
  28. * proxy admin cannot fallback to the target implementation.
  29. *
  30. * These properties mean that the admin account can only be used for upgrading the proxy, so it's best if it's a dedicated
  31. * account that is not used for anything else. This will avoid headaches due to sudden errors when trying to call a function
  32. * from the proxy implementation.
  33. *
  34. * Our recommendation is for the dedicated account to be an instance of the {ProxyAdmin} contract. If set up this way,
  35. * you should think of the `ProxyAdmin` instance as the real administrative interface of your proxy, which extends from the
  36. * {Ownable} contract to allow for changing the proxy's admin owner.
  37. *
  38. * NOTE: The real interface of this proxy is that defined in `ITransparentUpgradeableProxy`. This contract does not
  39. * inherit from that interface, and instead the admin functions are implicitly implemented using a custom dispatch
  40. * mechanism in `_fallback`. Consequently, the compiler will not produce an ABI for this contract. This is necessary to
  41. * fully implement transparency without decoding reverts caused by selector clashes between the proxy and the
  42. * implementation.
  43. *
  44. * IMPORTANT: This contract avoids unnecessary storage reads by setting the admin only during construction as an immutable variable,
  45. * preventing any changes thereafter. However, the admin slot defined in ERC-1967 can still be overwritten by the implementation
  46. * logic pointed to by this proxy. In such cases, the contract may end up in an undesirable state where the admin slot is different
  47. * from the actual admin.
  48. *
  49. * WARNING: It is not recommended to extend this contract to add additional external functions. If you do so, the compiler
  50. * will not check that there are no selector conflicts, due to the note above. A selector clash between any new function
  51. * and the functions declared in {ITransparentUpgradeableProxy} will be resolved in favor of the new one. This could
  52. * render the admin operations inaccessible, which could prevent upgradeability. Transparency may also be compromised.
  53. */
  54. contract TransparentUpgradeableProxy is ERC1967Proxy {
  55. // An immutable address for the admin avoid unnecessary SLOADs before each call
  56. // at the expense of removing the ability to change the admin once it's set.
  57. // This is acceptable if the admin is always a ProxyAdmin instance or similar contract
  58. // with its own ability to transfer the permissions to another account.
  59. address private immutable _admin;
  60. /**
  61. * @dev The proxy caller is the current admin, and can't fallback to the proxy target.
  62. */
  63. error ProxyDeniedAdminAccess();
  64. /**
  65. * @dev msg.value is not 0.
  66. */
  67. error ProxyNonPayableFunction();
  68. /**
  69. * @dev Initializes an upgradeable proxy managed by `_admin`, backed by the implementation at `_logic`, and
  70. * optionally initialized with `_data` as explained in {ERC1967Proxy-constructor}.
  71. */
  72. constructor(address _logic, address admin_, bytes memory _data) payable ERC1967Proxy(_logic, _data) {
  73. _admin = admin_;
  74. // Set the storage value and emit an event for ERC-1967 compatibility
  75. ERC1967Utils.changeAdmin(admin_);
  76. }
  77. /**
  78. * @dev If caller is the admin process the call internally, otherwise transparently fallback to the proxy behavior
  79. */
  80. function _fallback() internal virtual override {
  81. if (msg.sender == _admin) {
  82. bytes memory ret;
  83. bytes4 selector = msg.sig;
  84. if (selector == ITransparentUpgradeableProxy.upgradeTo.selector) {
  85. ret = _dispatchUpgradeTo();
  86. } else if (selector == ITransparentUpgradeableProxy.upgradeToAndCall.selector) {
  87. ret = _dispatchUpgradeToAndCall();
  88. } else {
  89. revert ProxyDeniedAdminAccess();
  90. }
  91. assembly {
  92. return(add(ret, 0x20), mload(ret))
  93. }
  94. } else {
  95. super._fallback();
  96. }
  97. }
  98. /**
  99. * @dev Upgrade the implementation of the proxy.
  100. */
  101. function _dispatchUpgradeTo() private returns (bytes memory) {
  102. _requireZeroValue();
  103. address newImplementation = abi.decode(msg.data[4:], (address));
  104. ERC1967Utils.upgradeToAndCall(newImplementation, bytes(""), false);
  105. return "";
  106. }
  107. /**
  108. * @dev Upgrade the implementation of the proxy, and then call a function from the new implementation as specified
  109. * by `data`, which should be an encoded function call. This is useful to initialize new storage variables in the
  110. * proxied contract.
  111. */
  112. function _dispatchUpgradeToAndCall() private returns (bytes memory) {
  113. (address newImplementation, bytes memory data) = abi.decode(msg.data[4:], (address, bytes));
  114. ERC1967Utils.upgradeToAndCall(newImplementation, data, true);
  115. return "";
  116. }
  117. /**
  118. * @dev To keep this contract fully transparent, the fallback is payable. This helper is here to enforce
  119. * non-payability of function implemented through dispatchers while still allowing value to pass through.
  120. */
  121. function _requireZeroValue() private {
  122. if (msg.value != 0) {
  123. revert ProxyNonPayableFunction();
  124. }
  125. }
  126. }