Explorar el Código

Fixed a broken payment test (+ another small fix) (#1318)

* Fixed a broken payment test

* In PR template, npm run lint:fix, not lint:all:fix

* In SplitPayment test, replaced an await-in-loop with Promise.all
dwardu hace 7 años
padre
commit
b79196f911
Se han modificado 2 ficheros con 4 adiciones y 4 borrados
  1. 1 1
      .github/PULL_REQUEST_TEMPLATE.md
  2. 3 3
      test/payment/SplitPayment.test.js

+ 1 - 1
.github/PULL_REQUEST_TEMPLATE.md

@@ -14,4 +14,4 @@ Fixes #
 - [ ] 📘 I've reviewed the [OpenZeppelin Contributor Guidelines](../blob/master/CONTRIBUTING.md)
 - [ ] ✅ I've added tests where applicable to test my new functionality.
 - [ ] 📖 I've made sure that my contracts are well-documented.
-- [ ] 🎨 I've run the JS/Solidity linters and fixed any issues (`npm run lint:all:fix`).
+- [ ] 🎨 I've run the JS/Solidity linters and fixed any issues (`npm run lint:fix`).

+ 3 - 3
test/payment/SplitPayment.test.js

@@ -51,10 +51,10 @@ contract('SplitPayment', function ([_, owner, payee1, payee2, payee3, nonpayee1,
     });
 
     it('should have payees', async function () {
-      this.payees.forEach(async (payee, index) => {
-        (await this.payee(index)).should.be.equal(payee);
+      await Promise.all(this.payees.map(async (payee, index) => {
+        (await this.contract.payee(index)).should.be.equal(payee);
         (await this.contract.released(payee)).should.be.bignumber.equal(0);
-      });
+      }));
     });
 
     it('should accept payments', async function () {