Browse Source

Now setting the finalized flag before doing finalization to prevent possbile reentrancy issues. (#1447)

Nicolás Venturo 7 years ago
parent
commit
5bb865218f
1 changed files with 2 additions and 3 deletions
  1. 2 3
      contracts/crowdsale/distribution/FinalizableCrowdsale.sol

+ 2 - 3
contracts/crowdsale/distribution/FinalizableCrowdsale.sol

@@ -34,10 +34,10 @@ contract FinalizableCrowdsale is TimedCrowdsale {
     require(!_finalized);
     require(hasClosed());
 
+    _finalized = true;
+
     _finalization();
     emit CrowdsaleFinalized();
-
-    _finalized = true;
   }
 
   /**
@@ -47,5 +47,4 @@ contract FinalizableCrowdsale is TimedCrowdsale {
    */
   function _finalization() internal {
   }
-
 }