Răsfoiți Sursa

Add Governor note for state changes between proposal creation and execution (#4766)

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Ernesto García 1 an în urmă
părinte
comite
552cffde56
1 a modificat fișierele cu 6 adăugiri și 0 ștergeri
  1. 6 0
      contracts/governance/IGovernor.sol

+ 6 - 0
contracts/governance/IGovernor.sol

@@ -317,6 +317,12 @@ interface IGovernor is IERC165, IERC6372 {
      * duration specified by {IGovernor-votingPeriod}.
      *
      * Emits a {ProposalCreated} event.
+     *
+     * NOTE: The state of the Governor and `targets` may change between the proposal creation and its execution.
+     * This may be the result of third party actions on the targeted contracts, or other governor proposals.
+     * For example, the balance of this contract could be updated or its access control permissions may be modified,
+     * possibly compromising the proposal's ability to execute successfully (e.g. the governor doesn't have enough
+     * value to cover a proposal with multiple transfers).
      */
     function propose(
         address[] memory targets,