Browse Source

Optimize Strings.equal (#4262)

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Igor Żuk 2 years ago
parent
commit
253bfa68c2
2 changed files with 6 additions and 1 deletions
  1. 5 0
      .changeset/eighty-crabs-listen.md
  2. 1 1
      contracts/utils/Strings.sol

+ 5 - 0
.changeset/eighty-crabs-listen.md

@@ -0,0 +1,5 @@
+---
+'openzeppelin-solidity': patch
+---
+
+Optimize `Strings.equal`

+ 1 - 1
contracts/utils/Strings.sol

@@ -80,6 +80,6 @@ library Strings {
      * @dev Returns true if the two strings are equal.
      */
     function equal(string memory a, string memory b) internal pure returns (bool) {
-        return keccak256(bytes(a)) == keccak256(bytes(b));
+        return bytes(a).length == bytes(b).length && keccak256(bytes(a)) == keccak256(bytes(b));
     }
 }