Prechádzať zdrojové kódy

node/pkg/db: document that VAAs may be stored multiple times

Change-Id: Ia32036b7e0f6afbe677a031628a3ed78f98184b7
Leo 4 rokov pred
rodič
commit
feb9919c0d
1 zmenil súbory, kde vykonal 6 pridanie a 1 odobranie
  1. 6 1
      node/pkg/db/db.go

+ 6 - 1
node/pkg/db/db.go

@@ -58,7 +58,12 @@ func (d *Database) StoreSignedVAA(v *vaa.VAA) error {
 
 	b, _ := v.Marshal()
 
-	// TODO: panic if same VAA is stored with different value
+	// We allow overriding of existing VAAs, since there are multiple ways to
+	// acquire signed VAA bytes. For instance, the node may have a signed VAA
+	// via gossip before it reaches quorum on its own. The new entry may have
+	// a different set of signatures, but the same VAA.
+	//
+	// TODO: panic on non-identical signing digest?
 
 	err := d.db.Update(func(txn *badger.Txn) error {
 		if err := txn.Set(VaaIDFromVAA(v).Bytes(), b); err != nil {