Browse Source

fix(staking): fix sorting by quality ranking when ranking is 0 (#1936)

Connor Prussin 1 year ago
parent
commit
816a33a9ad
1 changed files with 10 additions and 2 deletions
  1. 10 2
      apps/staking/src/components/OracleIntegrityStaking/index.tsx

+ 10 - 2
apps/staking/src/components/OracleIntegrityStaking/index.tsx

@@ -804,7 +804,15 @@ const doSort = (
       return value === 0 ? Number(a.poolCapacity - b.poolCapacity) : value;
     }
     case SortField.QualityRanking: {
-      return Number(a.qualityRanking - b.qualityRanking);
+      if (a.qualityRanking === 0 && b.qualityRanking === 0) {
+        return 0;
+      } else if (a.qualityRanking === 0) {
+        return 1;
+      } else if (b.qualityRanking === 0) {
+        return -1;
+      } else {
+        return Number(a.qualityRanking - b.qualityRanking);
+      }
     }
     case SortField.SelfStake: {
       return Number(a.selfStake - b.selfStake);
@@ -1029,7 +1037,7 @@ const Publisher = ({
           {publisher.numFeeds}
         </PublisherTableCell>
         <PublisherTableCell className="text-center">
-          {publisher.qualityRanking}
+          {publisher.qualityRanking === 0 ? "-" : publisher.qualityRanking}
         </PublisherTableCell>
         <PublisherTableCell
           className={clsx("text-right", { "pr-4 sm:pr-10": !isSelf })}