simd: '0162'
title: Remove Accounts is_executable Flag Checks
authors:
Remove all checks of accounts is_executable flag which can throw errors in
the runtime.
Currently, a program account which satisfies the following conditions can be invoked / executed:
is_executable flag setThe second condition can be used as a performance optimization to filter out accounts which definitely do not contain programs and the third condition alone would be sufficient to guarantee correct execution. The first condition is however is not only useless, it is downright deceptive and entangled with the confusing proxy account workaround in loader-v3.
Originally, the is_executable flag meant that a program was deployed and
finalized, which effectively renders its program account read-only forever,
as the is_executable can not be cleared / reset.
With the introduction of the upgradeable loader (loader-v3), instead of
removing the first condition back then, a workaround was created: The program
account became a proxy account which has the is_executable flag set and then
points to the actual program data account which does not have the
is_executable flag set. Meaning the is_executable flag now neither does
reliably indicate that an account contains a program (as the program data
account does not have the flag set), nor does it indicate that a program is
finalized (as the program account has it set while the program remains
upgradeable).
Removing the first condition not only removes some redundant error checks from the runtime and confusion for future maintainers, but more importantly enables us to deploy loader-v4 which is upgradeable like loader-v3 but without the need for proxy accounts.
None.
This proposal aims to unblock loader-v4 with minimal impact on the ecosystem by
only removing checks of the is_executable flag. A complete removal of the
flag can be addressed in a subsequent proposal. Thus, the following must remain
unaffected for now:
is_executable flag during program deployment in loader-v3is_executable flag for dappsis_executable flag setThese checks of the is_executable flag must be removed:
ExecutableLamportChange during execution (transaction succeeds instead)These checks of the is_executable flag do not influence whether transactions
fail or succeed because they are all covered by other checks. Thus, only the
thrown error codes will change, which does not affect consensus. Nevertheless,
they should still be removed because all implementations should aim to produce
the same error codes:
during transaction loading:
InvalidProgramForExecution (fallthrough to UnsupportedProgramId during
execution)AccountNotExecutable (fallthrough to UnsupportedProgramId during
execution)in the Upgrade instruction of loader-v3:
AccountNotExecutable
(fallthrough to IncorrectProgramId or InvalidAccountData, depending on
the owner)during execution:
AccountNotExecutable (fallthrough to UnsupportedProgramId during
execution)IncorrectProgramId (fallthrough to UnsupportedProgramId during
execution)ExecutableDataModified
(fallthrough to ExternalAccountDataModified during execution)ExecutableModified
(is unreachable, as it is overshadowed by owner and writability checks)ModifiedProgramId
(is unreachable, as it is overshadowed by owner and writability checks)Similarly the following checks during execution, unrelated to the
is_executable flag, but related to whether an account contains a program or
not, should be changed to throw UnsupportedProgramId instead:
InvalidAccountData for programs which are closed, in visibility delay,
failed verification or not owned by a loaderIncorrectProgramId for unrecognized built-in programsAll in all, the following error messages related to invocation of program
accounts will be coalesced into UnsupportedProgramId, but some of them will
remain in use in other circumstances unrelated to program execution:
InvalidProgramForExecutionAccountNotExecutableInvalidAccountDataIncorrectProgramIdUnsupportedProgramIdNone.
Error codes of these conditions, which are rarely triggered, will change.
The only consensus relevant change is that it will become possible (for everybody) to donate funds to program accounts. That however is expected not to break any existing programs.
None.