ci: add clippy rules back to cli call (#5953)

* ci: add clippy rules back to cli call

* clippy: allow clippy::arithmetic_side_effects in net-utils temporality

net-utils/src/lib.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::arithmetic_side_effects)]
+
 //! The `net_utils` module assists with networking
 mod ip_echo_client;
 mod ip_echo_server;

scripts/cargo-clippy-nightly.sh

@@ -24,4 +24,9 @@ source "$here/../ci/rust-version.sh" nightly
 #   ref: https://github.com/rust-lang/rust/issues/66287
 "$here/cargo-for-all-lock-files.sh" -- \
   "+${rust_nightly}" clippy \
-  --workspace --all-targets --features dummy-for-ci-check,frozen-abi
+  --workspace --all-targets --features dummy-for-ci-check,frozen-abi -- \
+  --deny=warnings \
+  --deny=clippy::default_trait_access \
+  --deny=clippy::arithmetic_side_effects \
+  --deny=clippy::manual_let_else \
+  --deny=clippy::used_underscore_binding